[webkit-reviews] review denied: [Bug 135904] Text caret changes to color of text in Mail and Notes : [Attachment 236572] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 135904: Text caret changes to color of text in Mail and Notes
https://bugs.webkit.org/show_bug.cgi?id=135904

Attachment 236572: Patch
https://bugs.webkit.org/attachment.cgi?id=236572&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=236572&action=review


> Source/WebCore/editing/FrameSelection.cpp:1511
> -    Element* element = node->isElementNode() ? toElement(node) :
node->parentElement();
> +    Element* element = node->rootEditableElement();

I don't think this is the right fix.

r152612 fixed the problem that the caret becomes invisible if the background
color of the current node matches that of the root editable element's text
color.

Our current behavior matches that of Firefox.