[webkit-reviews] review granted: [Bug 135637] [Mac] Unable to scroll to bottom of nested scrollable areas : [Attachment 236077] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 5 20:48:49 PDT 2014
Darin Adler <darin at apple.com> has granted Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 135637: [Mac] Unable to scroll to bottom of nested scrollable areas
https://bugs.webkit.org/show_bug.cgi?id=135637
Attachment 236077: Patch
https://bugs.webkit.org/attachment.cgi?id=236077&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236077&action=review
> Source/WebCore/rendering/RenderLayer.cpp:2603
> + IntSize scrollRange = maximumScrollPosition() - minimumScrollPosition();
> + if (orientation == HorizontalScrollbar)
> + return scrollRange.width();
> +
> + return scrollRange.height();
The blank line makes this read awkwardly. I think ? : would be nicer.
More information about the webkit-reviews
mailing list