[webkit-reviews] review granted: [Bug 135638] HashTable based classes leak a lot : [Attachment 236078] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 135638: HashTable based classes leak a lot
https://bugs.webkit.org/show_bug.cgi?id=135638

Attachment 236078: Patch
https://bugs.webkit.org/attachment.cgi?id=236078&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236078&action=review


Another fix would be to just add these two lines:

    if (m_table)
	deallocateTable(m_table, m_tableSize);

I suppose the swap idiom is more elegant, but it would be nice to double check
that it’s just as efficient too.

> Source/WTF/wtf/HashTable.h:1236
> +	   HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>
temp = WTF::move(other);

You could write just HashTable here or just auto. No need for that long
HashTable<xxxxxxxx> thing.