[webkit-reviews] review granted: [Bug 135631] Cleanup InlineTextBox::paintSelection and ::localSelectionRect. : [Attachment 236074] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Zalan Bujtas <zalan at apple.com>'s
request for review:
Bug 135631: Cleanup InlineTextBox::paintSelection and ::localSelectionRect.
https://bugs.webkit.org/show_bug.cgi?id=135631

Attachment 236074: Patch
https://bugs.webkit.org/attachment.cgi?id=236074&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236074&action=review


> Source/WebCore/ChangeLog:8
> +	   No change in functionality.

But we removed the snapping from localSelectionRect. That seems like a bug fix,
not a “no change” refactoring fix.

> Source/WebCore/rendering/InlineTextBox.cpp:740
> +    LayoutUnit selectionTop =
root().selectionTopAdjustedForPrecedingBlock();

No need to put this into local variable any more if we are only using this
once.