[webkit-reviews] review granted: [Bug 135625] Add the ability to force text to render in white, not just black : [Attachment 236057] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Peyton Randolph
<prandolph at apple.com>'s request for review:
Bug 135625: Add the ability to force text to render in white, not just black
https://bugs.webkit.org/show_bug.cgi?id=135625

Attachment 236057: Patch
https://bugs.webkit.org/attachment.cgi?id=236057&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236057&action=review


> Source/WebCore/rendering/InlineTextBox.cpp:631
> +    const ShadowData* textShadow = (paintInfo.forceTextColor()) ? 0 :
lineStyle.textShadow();

0 -> nullptr

> Source/WebCore/rendering/PaintPhase.h:63
> +    PaintBehaviorForceWhiteText = 1 << 6,

Please put this under PaintBehaviorForceBlackText and change the numbers.

> Source/WebCore/rendering/TextPaintStyle.cpp:142
> +	   const ShadowData* shadow = paintInfo.forceTextColor() ? 0 :
pseudoStyle->textShadow();

0 -> nullptr