[webkit-reviews] review denied: [Bug 135506] Scrolling with spacebar on a page with fixed header breaks reading flow : [Attachment 236059] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied  review:
Bug 135506: Scrolling with spacebar on a page with fixed header breaks reading
flow
https://bugs.webkit.org/show_bug.cgi?id=135506

Attachment 236059: Patch
https://bugs.webkit.org/attachment.cgi?id=236059&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236059&action=review


> Source/WebCore/page/FrameView.cpp:3199
> +    for (const auto slot : *positionedObjects) {

slot -> positionedObject

> Source/WebCore/page/FrameView.cpp:3218
> +	   if (fixedRectInView.y() == unobscuredContentRect.y())
> +	       topObscuredArea = std::max(topObscuredArea,
fixedRectInView.height());
> +	   else if (fixedRectInView.maxY() == unobscuredContentRect.maxY())
> +	       bottomObscuredArea = std::max(bottomObscuredArea,
fixedRectInView.height());
> +    }
> +    return std::max<float>(0, step - topObscuredArea - bottomObscuredArea);

I think the behavior when the fixed object covers most of the view is
undesirable. I would limit this to fixed objects which are obviously bars
(maybe < 20% of view height).

Also, there are sites with fully transparent position:fixed that cover much of
the page, and this would make scrolling really funky on such pages.