[webkit-reviews] review granted: [Bug 135480] Inspector highlights clipped at the bottom on the page in WK1 views with contentInsets : [Attachment 235899] Patch with a new name

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 135480: Inspector highlights clipped at the bottom on the page in WK1 views
with contentInsets
https://bugs.webkit.org/show_bug.cgi?id=135480

Attachment 235899: Patch with a new name
https://bugs.webkit.org/attachment.cgi?id=235899&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235899&action=review


Is this testable?

> Source/WebCore/platform/ScrollView.h:485
>      IntRect platformVisibleContentRect(bool includeScrollbars) const;
>      IntSize platformVisibleContentSize(bool includeScrollbars) const;
> +    IntRect platformVisibleContentRectIncludingObscuredArea(bool
includeScrollbars) const;
> +    IntSize platformVisibleContentSizeIncludingObscuredArea(bool
includeScrollbars) const;

It almost feels like the "including obscured area" could be an enum param to
platformVisibleContentRect/Size.