[webkit-reviews] review denied: [Bug 135515] Create stub long mouse press controller. Part of 135257 - Add long mouse press gesture : [Attachment 235894] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Peyton Randolph
<prandolph at apple.com>'s request for review:
Bug 135515: Create stub long mouse press controller. Part of 135257 - Add long
mouse press gesture
https://bugs.webkit.org/show_bug.cgi?id=135515

Attachment 235894: Patch
https://bugs.webkit.org/attachment.cgi?id=235894&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235894&action=review


> Source/WebCore/page/ChromeClient.h:198
> +    virtual void startLongMousePress(const IntPoint&) const = 0;

This should be didStartLongMousePress, right?

> Source/WebCore/page/ChromeClient.h:199
> +    virtual void triggerLongMousePress() const = 0;

triggered?

> Source/WebCore/page/ChromeClient.h:200
> +    virtual void cancelLongMousePress() const = 0;

didCancel?

> Source/WebKit2/Shared/LongMousePressData.h:48
> +    String urlString;

Can this be a URL?

> Source/WebKit2/WebProcess/WebPage/LongMousePressController.h:50
> +    __unused WebPage* m_webPage;

Weird.

> Source/WebKit2/WebProcess/WebPage/WebPage.h:1176
> +    LongMousePressController m_longMousePressController;

Can we store in a unique_pointer and only allocate when we need one?