[webkit-reviews] review granted: [Bug 132379] AX: Make "contenteditable" regions into AXTextAreas : [Attachment 230466] patch

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <mario at webkit.org> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 132379: AX: Make "contenteditable" regions into AXTextAreas
https://bugs.webkit.org/show_bug.cgi?id=132379

Attachment 230466: patch
https://bugs.webkit.org/attachment.cgi?id=230466&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=230466&action=review


Looks good, just a couple of comments below

>
LayoutTests/platform/mac/accessibility/content-editable-as-textarea-expected.tx
t:32
> +    AXMarkedMisspelled = 1;

This line is not being output when running the test in the Mac bots. Guess you
should just remove it from here?

> LayoutTests/platform/mac/accessibility/content-editable-as-textarea.html:32
> +	       window.testRunner.notifyDone();
> +	   }
> +    }
> +
> +    if (window.accessibilityController) {
> +	   window.testRunner.waitUntilDone();

I think the "trend" these days is to declare window.jsTestIsAsync = true; and
call finishJSTest() when done, instead of using waitUntilDone() and
notifyDone().

Could you change that before landing?