[webkit-reviews] review denied: [Bug 121548] [GTK] TLSErrors do not cause page load to fail when not ignored : [Attachment 211983] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has denied Brian Holt
<brian.holt at samsung.com>'s request for review:
Bug 121548: [GTK] TLSErrors do not cause page load to fail when not ignored
https://bugs.webkit.org/show_bug.cgi?id=121548

Attachment 211983: Patch
https://bugs.webkit.org/attachment.cgi?id=211983&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211983&action=review


> Source/WebCore/ChangeLog:8
> +	   No new tests (OOPS!).

You should remove this, commit-queue will refuse to land this patch with this
line here.

> Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp:71
> +    GTlsCertificateFlags tlsFlags = static_cast<GTlsCertificateFlags>(0);

I would use tldErrors instead of tlsFlasg for consistency, making clear that
this is the same as m_tlsErrors