[webkit-reviews] review granted: [Bug 131976] WKThumbnailView doesn't quite work with topContentInset : [Attachment 229871] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 131976: WKThumbnailView doesn't quite work with topContentInset
https://bugs.webkit.org/show_bug.cgi?id=131976

Attachment 229871: patch
https://bugs.webkit.org/attachment.cgi?id=229871&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=229871&action=review


> Source/WebKit2/UIProcess/API/Cocoa/_WKThumbnailView.mm:90
> +    _lastSnapshotScale = 0;

Could consider NaN instead for uses like this.

> Source/WebKit2/UIProcess/API/Cocoa/_WKThumbnailView.mm:126
> -    IntRect snapshotRect(IntPoint(), _webPageProxy->viewSize());
> +    IntRect snapshotRect(IntPoint(),
IntSize(_webPageProxy->viewSize().width(), _webPageProxy->viewSize().height() -
_webPageProxy->topContentInset()));

Is there a way to write this math simpler? Like maybe this:

    IntRect snapshotRect(IntPoint(), _webPageProxy->viewSize() - IntSize(0,
_webPageProxy->topContentInset()));