[webkit-reviews] review granted: [Bug 131949] REGRESSION (r157328): popover to check into flight ba.com dismisses instantly when focusing form : [Attachment 229863] Fixes the bug

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 131949: REGRESSION (r157328): popover to check into flight ba.com dismisses
instantly when focusing form
https://bugs.webkit.org/show_bug.cgi?id=131949

Attachment 229863: Fixes the bug
https://bugs.webkit.org/attachment.cgi?id=229863&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=229863&action=review


Patch seems fine, but I find the indirect way all this code is written really
confusing.

The new test seems to be failing on EWS, so please check to be sure that’s
resolved before landing.

> Source/WebCore/dom/EventDispatcher.cpp:180
> +	   Node* previousHost = 0;

nullptr

> Source/WebCore/dom/EventDispatcher.cpp:192
> +	   return 0;

nullptr