[webkit-reviews] review granted: [Bug 131612] JavaScriptCore: ARM build fix after r167094. : [Attachment 229442] Patch

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has granted László Langó
<llango.u-szeged at partner.samsung.com>'s request for review:
Bug 131612: JavaScriptCore: ARM build fix after r167094.
https://bugs.webkit.org/show_bug.cgi?id=131612

Attachment 229442: Patch
https://bugs.webkit.org/attachment.cgi?id=229442&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=229442&action=review


> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:745
> +    elsif ARM or ARMv7 or ARMv7_TRADITIONAL
> +	   mvlbl (label - _relativePCBase), t2
> +	   addp t2, t1, t2
> +	   move index, t3
> +	   storep t2, [a0, t3, 4]
> +    elsif SH4

If the issue only manifests with ARM traditional (not Thumb2), could you make
this "elsif ARM or ARMv7_TRADITIONAL"?

> Source/JavaScriptCore/offlineasm/arm.rb:489
> +	   when "mvlbl"
> +		   $asm.puts "movw #{operands[1].armOperand},
\#:lower16:#{operands[0].value}"
> +		   $asm.puts "movt #{operands[1].armOperand},
\#:upper16:#{operands[0].value}"

I believe that the movw is sufficient.