[webkit-reviews] review granted: [Bug 131696] Only webkit2 pages should have a page throttler. : [Attachment 229502] new patch for real this time

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Stephanie Lewis
<slewis at apple.com>'s request for review:
Bug 131696: Only webkit2 pages should have a page throttler.
https://bugs.webkit.org/show_bug.cgi?id=131696

Attachment 229502: new patch for real this time
https://bugs.webkit.org/attachment.cgi?id=229502&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=229502&action=review


> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1750
> +    if (m_page->pageThrottler())

WebPage's m_page should always have a throttler (per call to
createPageThrottler, above).
This should just be an ASSERT.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1819
> +    if(m_page->pageThrottler())

ditto.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1851
> +    if (m_page->pageThrottler())

ditto.