[webkit-reviews] review granted: [Bug 131406] Web Inspector: Prevent deadlocks receiving WIRPermissionDenied message : [Attachment 228907] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 131406: Web Inspector: Prevent deadlocks receiving WIRPermissionDenied
message
https://bugs.webkit.org/show_bug.cgi?id=131406

Attachment 228907: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=228907&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228907&action=review


> Source/JavaScriptCore/inspector/remote/RemoteInspector.h:68
> +    enum StopSource { StopSourceAPI, StopSourceXPCMessage };

IIRC, we don't typically repeat the enum name. So:

enum StopSource { API, XPCMessage };

But I could be wrong.