[webkit-reviews] review requested: [Bug 130523] Need target to produce llvm ir : [Attachment 228911] Added target to produce llvm ir for JavaScriptCore. WIP for C++ inlining.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 8 16:32:08 PDT 2014


Matthew Mirman <mmirman at apple.com> has asked  for review:
Bug 130523: Need target to produce llvm ir
https://bugs.webkit.org/show_bug.cgi?id=130523

Attachment 228911: Added target to produce llvm ir for JavaScriptCore.	WIP for
C++ inlining.
https://bugs.webkit.org/attachment.cgi?id=228911&action=review

------- Additional Comments from Matthew Mirman <mmirman at apple.com>
Does not handle stale Runtime.symtbl 

The worst thing that can occur is that the symbol table will contain symbols
which no longer exist.	At the moment this will have no effect on runtime since
Runtime.symtbl is not used.
When Runtime.symtbl is being used (patch forthcoming), either the symbols will
never be accessed (since they don't exist exposed in runtime, they can't be
called by js code), or when they are accessed the FTL code will simply not
inline them after catching an error.


More information about the webkit-reviews mailing list