[webkit-reviews] review granted: [Bug 131241] Web Inspector: Log JS Exceptions to System Console if JavaScriptCoreOutputConsoleMessagesToSystemConsole enabled : [Attachment 228620] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 131241: Web Inspector: Log JS Exceptions to System Console if
JavaScriptCoreOutputConsoleMessagesToSystemConsole enabled
https://bugs.webkit.org/show_bug.cgi?id=131241

Attachment 228620: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=228620&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228620&action=review


> Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp:162
> +	       ConsoleClient::printConsoleMessage(MessageSource::JS,
MessageType::Log, MessageLevel::Error, errorMessage, callFrame.sourceURL(),
callFrame.lineNumber(), callFrame.columnNumber());

Would be good to print the whole stack by passing in callStack and treating it
like a console.trace.