[webkit-reviews] review granted: [Bug 131246] Enhanced GC logging : [Attachment 228631] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 131246: Enhanced GC logging
https://bugs.webkit.org/show_bug.cgi?id=131246

Attachment 228631: Patch
https://bugs.webkit.org/attachment.cgi?id=228631&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228631&action=review


r=me

> Source/JavaScriptCore/heap/GCLogging.cpp:106
> +    loggingFunctor.reviveCells();

If the revive call here is required in order to return the heap to a good
state, then I think either LoggingFunctor::log() or
LoggingFunctor::~LoggingFunctor() should do it automatically.