[webkit-reviews] review granted: [Bug 131108] [EFL] Should flush and render layers after the root layer is changed. : [Attachment 228476] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 3 22:28:59 PDT 2014


Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted Hyowon Kim
<hw1008.kim at samsung.com>'s request for review:
Bug 131108: [EFL] Should flush and render layers after the root layer is
changed.
https://bugs.webkit.org/show_bug.cgi?id=131108

Attachment 228476: Patch
https://bugs.webkit.org/attachment.cgi?id=228476&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228476&action=review


r=me. Please land it after applying my comment.

> Source/WebKit/efl/WebCoreSupport/AcceleratedCompositingContextEfl.cpp:185
> +{

Please add ASSERT(rootLayer); It looks rootLayer can be null when user set it
as null by using ewk_view_root_graphics_layer_set().


More information about the webkit-reviews mailing list