[webkit-reviews] review granted: [Bug 131194] [Win] Load Media Controls js/css from bundle : [Attachment 228578] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 131194: [Win] Load Media Controls js/css from bundle
https://bugs.webkit.org/show_bug.cgi?id=131194

Attachment 228578: Patch
https://bugs.webkit.org/attachment.cgi?id=228578&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228578&action=review


> Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters:7092
> +    <ClCompile Include="..\platform\DisplaySleepDisabler.cpp" />
> +    <ClCompile Include="..\platform\SystemSleepListener.cpp" />

There are a lot of changes to this file, but I assume it's either unintentional
and you'll remove it, or intentional and you know what you are doing!

> Source/WebCore/rendering/RenderThemeSafari.h:188
> +    bool m_mediaControlsScriptLoaded;
> +    bool m_mediaControlsStyleSheetLoaded;

There was a followup commit where I skipped the booleans and just checked if
the string was empty.

> Source/WebCore/rendering/RenderThemeWin.cpp:1117
> +    // Open the file

Nit: end with .