[webkit-reviews] review granted: [Bug 122001] [GStreamer] Expose MPEG-TS metadata : [Attachment 228446] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Brendan Long
<b.long at cablelabs.com>'s request for review:
Bug 122001: [GStreamer] Expose MPEG-TS metadata
https://bugs.webkit.org/show_bug.cgi?id=122001

Attachment 228446: Patch
https://bugs.webkit.org/attachment.cgi?id=228446&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228446&action=review


>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1072

> +	   track->client()->addDataCue(track.get(), currentTimeDouble(),
currentTimeDouble(), bytes, size);

Nit: it would be cleaner to have track->addDataCue() so you don't have to call
the client interface directly.