[webkit-reviews] review denied: [Bug 130391] [EFL] [WK2] Replacing zoom functionality of MiniBrowser from scale_set to page_zoom_set : [Attachment 228401] proposed patch 4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 2 18:46:05 PDT 2014


Gyuyoung Kim <gyuyoung.kim at samsung.com> has denied Andrzej Badowski
<a.badowski at samsung.com>'s request for review:
Bug 130391: [EFL] [WK2] Replacing zoom functionality of MiniBrowser from
scale_set to page_zoom_set
https://bugs.webkit.org/show_bug.cgi?id=130391

Attachment 228401: proposed patch 4
https://bugs.webkit.org/attachment.cgi?id=228401&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228401&action=review


r- due to some nits.

> Source/WebKit2/ChangeLog:3
> +	   [EFL] [WK2] Replacing zoom functionality of MiniBrowser from
scale_set to page_zoom_set.

Unnecessary a space between [EFL] and [WK2]

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:245
> +    WKPageSetPageZoomFactor(impl->wkPage(), zoomFactor);

Add a new line.


More information about the webkit-reviews mailing list