[webkit-reviews] review granted: [Bug 131057] Remove Settings::maximumDecodedImageSize() : [Attachment 228319] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 2 09:56:10 PDT 2014


Darin Adler <darin at apple.com> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 131057: Remove Settings::maximumDecodedImageSize()
https://bugs.webkit.org/show_bug.cgi?id=131057

Attachment 228319: Patch
https://bugs.webkit.org/attachment.cgi?id=228319&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228319&action=review


> Source/WebCore/loader/cache/CachedImage.cpp:400
> +	   // The image failed to be decoded. Either we need more image data or
the image data is malformed.

"failed to be decoded" is not grammatical. I suggest "Image decoding failed."

> Source/WebCore/loader/cache/CachedImage.cpp:439
> +	   // The image failed to be decoded; the image data is malformed.

Ditto.


More information about the webkit-reviews mailing list