[webkit-reviews] review denied: [Bug 130308] bad values from HTMLImageElement x and y attributes (CSSOM-View) : [Attachment 228391] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Jeongeun Kim
<je_julie.kim at samsung.com>'s request for review:
Bug 130308: bad values from HTMLImageElement x and y attributes (CSSOM-View)
https://bugs.webkit.org/show_bug.cgi?id=130308

Attachment 228391: Patch
https://bugs.webkit.org/attachment.cgi?id=228391&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228391&action=review


The right basic idea here, but incorrect implementation.

> Source/WebCore/html/HTMLImageElement.cpp:382
> +    document().updateStyleIfNeeded();

The correct call to make here is:

    document().updateLayoutIgnorePendingStylesheets();

See Element::offsetLeft for an example of how to do it.

> Source/WebCore/html/HTMLImageElement.cpp:389
> +    if (renderer->needsLayout())
> +	   document().updateLayout();

This is not needed. Please don’t add it.

> Source/WebCore/html/HTMLImageElement.cpp:397
> +    document().updateStyleIfNeeded();

Same comment as above.

> Source/WebCore/html/HTMLImageElement.cpp:404
> +    if (renderer->needsLayout())
> +	   document().updateLayout();

This is not needed. Please don’t add it.