[webkit-reviews] review denied: [Bug 131006] std::bind not compiling with Visual Studio : [Attachment 228238] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has denied Alex Christensen
<alex.christensen at flexsim.com>'s request for review:
Bug 131006: std::bind not compiling with Visual Studio
https://bugs.webkit.org/show_bug.cgi?id=131006

Attachment 228238: Patch
https://bugs.webkit.org/attachment.cgi?id=228238&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228238&action=review


We use the versions with the bool function to decide whether to use g_idle or
g_timeout, if you remove the versions receiving a bool function it's impossible
to implement a repeating source. I guess the problem with visual studio is that
the compiler doesn't know which one to use, so a possible workaround would be
to add a cast in the callers, see the discussion here:
https://bugs.webkit.org/show_bug.cgi?id=130027#c15

> Source/WTF/ChangeLog:4
> +	   [WinCairo] Build fix after r166496.
> +	   https://bugs.webkit.org/show_bug.cgi?id=131006

Removing the code that doesn't build for you is not a build fix :-)