[webkit-reviews] review denied: [Bug 130343] REGRESSION(r165704): [GTK] Inspector resources not correctly generated : [Attachment 227146] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has denied Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 130343: REGRESSION(r165704): [GTK] Inspector resources not correctly
generated
https://bugs.webkit.org/show_bug.cgi?id=130343

Attachment 227146: Patch
https://bugs.webkit.org/attachment.cgi?id=227146&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
Patch looks good to me in general, but please, don't compile the resources in
WebCore, but in libwebkit and libwebkit2, even if there are some rules
duplicated in cmake files we are going to remove the wk1 ones soon, so it's not
a problem. Also consider using the file descriptor instead of buffering the
whole file.