[webkit-reviews] review denied: [Bug 118520] Move PlatformCertificateInfo to WebCore and make the ResourceResponse primitives work in terms of that platform agnostic object : [Attachment 213036] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has denied Csaba Osztrogonac
<ossy at webkit.org>'s request for review:
Bug 118520: Move PlatformCertificateInfo to WebCore and make the
ResourceResponse primitives work in terms of that platform agnostic object
https://bugs.webkit.org/show_bug.cgi?id=118520

Attachment 213036: Patch
https://bugs.webkit.org/attachment.cgi?id=213036&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213036&action=review


soup changes look good to me, except for the few comments below. r- just
because of the SoupMessageFlags initialization removal in ResourceResponse.

> Source/WebCore/platform/network/PlatformCertificateInfo.h:35
> +#include <wtf/gobject/GRefPtr.h>

We can probably include <gio/gio.h> since we are not using any libsoup API
here.

> Source/WebCore/platform/network/PlatformCertificateInfo.h:40
> +class ResourceError;
> +class ResourceResponse;

These look unused here.

> Source/WebCore/platform/network/soup/PlatformCertificateInfoSoup.cpp:31
> +#include "ResourceError.h"
> +#include "ResourceResponse.h"

These are no longer needed either.

> Source/WebCore/platform/network/soup/PlatformCertificateInfoSoup.cpp:32
> +#include <libsoup/soup.h>

This is already included in PlatformCertificateInfo.h, I know this is also
present in current code, though.

> Source/WebCore/platform/network/soup/ResourceResponse.h:-40
> -	   , m_soupFlags(static_cast<SoupMessageFlags>(0))

You should keep the message flags initialization.

> Source/WebCore/platform/network/soup/ResourceResponse.h:-47
> -	   , m_soupFlags(static_cast<SoupMessageFlags>(0))

Ditto.

> Source/WebCore/platform/network/soup/ResourceResponse.h:-54
> -	   , m_soupFlags(static_cast<SoupMessageFlags>(0))

Ditto.