[webkit-reviews] review denied: [Bug 122120] [GTK] Add WK2 settings property for respect image orientation : [Attachment 213029] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 30 23:18:30 PDT 2013


Carlos Garcia Campos <cgarcia at igalia.com> has denied Anton Obzhirov
<a.obzhirov at samsung.com>'s request for review:
Bug 122120: [GTK] Add WK2 settings property for respect image orientation
https://bugs.webkit.org/show_bug.cgi?id=122120

Attachment 213029: Patch
https://bugs.webkit.org/attachment.cgi?id=213029&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213029&action=review


I'm sorry I forgot to say in the other bug that you should also update the
WebKitSettings unit tests. This is new API, so at least another GTK+ reviewer
should approve it.

> Source/WebKit2/ChangeLog:8
> +	   Add respect image orientation property in WK2

You should explain this a bit better, this is not a new property of WK2, but a
new setting/property added to WebKitSettings API.


More information about the webkit-reviews mailing list