[webkit-reviews] review denied: [Bug 122062] Web Inspector: content view in back/forward list multiple times won't restore earlier positions : [Attachment 212900] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Sep 28 08:53:10 PDT 2013
Timothy Hatcher <timothy at apple.com> has denied Brian Burg
<burg at cs.washington.edu>'s request for review:
Bug 122062: Web Inspector: content view in back/forward list multiple times
won't restore earlier positions
https://bugs.webkit.org/show_bug.cgi?id=122062
Attachment 212900: Patch
https://bugs.webkit.org/attachment.cgi?id=212900&action=review
------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=212900&action=review
Looks good. The Object.shallowEqual issue is the only big issue.
> Source/WebInspectorUI/UserInterface/BackForwardEntry.js:36
> + restorePositions: function()
I think restoreCookie would be a better name. There is nothing about
"positions" that this explicitly restores.
More information about the webkit-reviews
mailing list