[webkit-reviews] review granted: [Bug 122053] filter: drop-shadow doesnot support viewport units : [Attachment 212885] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted gur.trio at gmail.com's request for
review:
Bug 122053: filter: drop-shadow doesnot support viewport units
https://bugs.webkit.org/show_bug.cgi?id=122053

Attachment 212885: Patch
https://bugs.webkit.org/attachment.cgi?id=212885&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=212885&action=review


> Source/WebCore/css/StyleResolver.cpp:3877
> +	       if (item->x->isViewportPercentageLength())
> +		   x = viewportPercentageValue(*item->x, x);

Maybe we should have a function that does this dance. I have noticed that we
have to repeat this idiom at every call site. If the inline call to
isViewportPercentageLength is important for performance, we can make the
function do it inline. I’d want to go back and do this for as many of the
places we use viewportPercentageValue as possible. I don’t like repetitive
idioms like this one when they are unnecessary.