[webkit-reviews] review granted: [Bug 121930] Implement prefixed-destructuring assignment : [Attachment 212652] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 26 09:31:13 PDT 2013

Mark Hahnenberg <mhahnenberg at apple.com> has granted Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 121930: Implement prefixed-destructuring assignment

Attachment 212652: Patch

------- Additional Comments from Mark Hahnenberg <mhahnenberg at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=212652&action=review


> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:398
>  }

Side note: the BytecodeGenerator constructor seems like it does waaay too much
stuff. Maybe we should factor some of this functionality out into separate
helper functions?

> Source/JavaScriptCore/parser/ASTBuilder.h:322
> +    ParameterNode* createFormalParameterList(DeconstructionPattern pattern)
{ return new (m_vm) ParameterNode(pattern); }
> +    ParameterNode* createFormalParameterList(ParameterNode* list,
DeconstructionPattern pattern) { return new (m_vm) ParameterNode(list,
pattern); }

It's sad that we can't do PassRefPtrs here, but hopefully move semantics will
save us.

More information about the webkit-reviews mailing list