[webkit-reviews] review denied: [Bug 110097] [WK2] Port RemoteNetworkingContext for Soup : [Attachment 212710] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Csaba Osztrogonac <ossy at webkit.org>'s
request for review:
Bug 110097: [WK2] Port RemoteNetworkingContext for Soup
https://bugs.webkit.org/show_bug.cgi?id=110097

Attachment 212710: Patch
https://bugs.webkit.org/attachment.cgi?id=212710&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=212710&action=review


> Source/WebKit2/NetworkProcess/RemoteNetworkingContext.h:34
> +class RemoteNetworkingContext : public WebCore::NetworkingContext {

As long as you are touching this, should mark this class FINAL.

> Source/WebKit2/NetworkProcess/RemoteNetworkingContext.h:54
> +    RemoteNetworkingContext(bool privateBrowsingEnabled, bool
shouldClearReferrerOnHTTPSToHTTPRedirect)
> +	   : m_privateBrowsingEnabled(privateBrowsingEnabled)
> +	   ,
m_shouldClearReferrerOnHTTPSToHTTPRedirect(shouldClearReferrerOnHTTPSToHTTPRedi
rect)
> +    { }

This will leave m_needsSiteSpecificQuirks and m_localFileContentSniffingEnabled
uninitialized on PLATFORM(MAC), which is not what we want.