[webkit-reviews] review denied: [Bug 110097] [WK2] Port RemoteNetworkingContext for Soup : [Attachment 212710] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 26 09:29:55 PDT 2013

Darin Adler <darin at apple.com> has denied Csaba Osztrogonac <ossy at webkit.org>'s
request for review:
Bug 110097: [WK2] Port RemoteNetworkingContext for Soup

Attachment 212710: Patch

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=212710&action=review

> Source/WebKit2/NetworkProcess/RemoteNetworkingContext.h:34
> +class RemoteNetworkingContext : public WebCore::NetworkingContext {

As long as you are touching this, should mark this class FINAL.

> Source/WebKit2/NetworkProcess/RemoteNetworkingContext.h:54
> +    RemoteNetworkingContext(bool privateBrowsingEnabled, bool
> +	   : m_privateBrowsingEnabled(privateBrowsingEnabled)
> +	   ,
> +    { }

This will leave m_needsSiteSpecificQuirks and m_localFileContentSniffingEnabled
uninitialized on PLATFORM(MAC), which is not what we want.

More information about the webkit-reviews mailing list