[webkit-reviews] review requested: [Bug 121558] [ATK] Protect entry points in the ATK wrapper against outdated render trees : [Attachment 212695] Patch proposal
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 26 05:52:58 PDT 2013
Mario Sanchez Prada <mario at webkit.org> has asked for review:
Bug 121558: [ATK] Protect entry points in the ATK wrapper against outdated
render trees
https://bugs.webkit.org/show_bug.cgi?id=121558
Attachment 212695: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=212695&action=review
------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
Attaching new patch addressing the issues pointed out by Chris.
(In reply to comment #21)
> (In reply to comment #20)
> > (From update of attachment 212582 [details] [details])
> > View in context:
https://bugs.webkit.org/attachment.cgi?id=212582&action=review
> >
> > > Source/WebCore/accessibility/atk/WebKitAccessibleUtil.h:38
> > > +#define returnIfObjectIsInvalid(webkitAccessible) G_STMT_START { \
> >
> Ok. Another option would be to rename the method to
returnIfAccessibleIsInvalid, or even returnIfWebKitAccessibleIsInvalid, but I
guess just changing the parameter name should be enough.
Actually I think I really prefer returnIfWebKitAccessibleIsInvalid() since that
way is clear that a WebKitAccessible (subclass of AtkObject) is expected. I
changed that in this new patch
More information about the webkit-reviews
mailing list