[webkit-reviews] review canceled: [Bug 121558] [ATK] Protect entry points in the ATK wrapper against outdated render trees : [Attachment 212582] Patch proposal plus new Layout test

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <mario at webkit.org> has canceled Mario Sanchez Prada
<mario at webkit.org>'s request for review:
Bug 121558: [ATK] Protect entry points in the ATK wrapper against outdated
render trees
https://bugs.webkit.org/show_bug.cgi?id=121558

Attachment 212582: Patch proposal plus new Layout test
https://bugs.webkit.org/attachment.cgi?id=212582&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
Attaching new patch addressing the issues pointed out by Chris.

(In reply to comment #21)
> (In reply to comment #20)
> > (From update of attachment 212582 [details] [details])
> > View in context:
https://bugs.webkit.org/attachment.cgi?id=212582&action=review
> > 
> > > Source/WebCore/accessibility/atk/WebKitAccessibleUtil.h:38
> > > +#define returnIfObjectIsInvalid(webkitAccessible) G_STMT_START { \
> > 
> Ok. Another option would be to rename the method to
returnIfAccessibleIsInvalid, or even returnIfWebKitAccessibleIsInvalid, but I
guess just changing the parameter name should be enough.

Actually I think I really prefer returnIfWebKitAccessibleIsInvalid() since that
way is clear that a WebKitAccessible (subclass of AtkObject) is expected. I
changed that in this new patch