[webkit-reviews] review requested: [Bug 121867] Change JSC debug hooks to pass a CallFrame* instead of a DebuggerCallFrame. : [Attachment 212519] JavaScriptCallFrame is now constructed with DebuggerCallFrame as an arg again. Added all the suggested FINAL and OVERRIDE clauses. Also cached line and column in DebuggerCallFrame.

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has asked  for review:
Bug 121867: Change JSC debug hooks to pass a CallFrame* instead of a
DebuggerCallFrame.
https://bugs.webkit.org/show_bug.cgi?id=121867

Attachment 212519: JavaScriptCallFrame is now constructed with
DebuggerCallFrame as an arg again. Added all the suggested FINAL and OVERRIDE
clauses. Also cached line and column in DebuggerCallFrame.
https://bugs.webkit.org/attachment.cgi?id=212519&action=review

------- Additional Comments from Mark Lam <mark.lam at apple.com>
However, I did not change the JSC debug hooks to pass a CallFrame& instead of
the CallFrame*.  This is in keeping with the convention of how we pass
CallFrames in JSC.  Eventually, these debug hook code should move back into
JSC::Debugger, and no one outside of JSC will see them.