[webkit-reviews] review canceled: [Bug 121867] Change JSC debug hooks to pass a CallFrame* instead of a DebuggerCallFrame. : [Attachment 212500] the patch.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 24 16:34:35 PDT 2013
Mark Lam <mark.lam at apple.com> has canceled Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 121867: Change JSC debug hooks to pass a CallFrame* instead of a
DebuggerCallFrame.
https://bugs.webkit.org/show_bug.cgi?id=121867
Attachment 212500: the patch.
https://bugs.webkit.org/attachment.cgi?id=212500&action=review
------- Additional Comments from Mark Lam <mark.lam at apple.com>
However, I did not change the JSC debug hooks to pass a CallFrame& instead of
the CallFrame*. This is in keeping with the convention of how we pass
CallFrames in JSC. Eventually, these debug hook code should move back into
JSC::Debugger, and no one outside of JSC will see them.
More information about the webkit-reviews
mailing list