[webkit-reviews] review denied: [Bug 121782] [GTK] Add --disable-drag-support build option to remove dragging functionality : [Attachment 212338] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 23 06:02:28 PDT 2013


Gustavo Noronha (kov) <gns at gnome.org> has denied Lorenzo Tilve
<ltilve at igalia.com>'s request for review:
Bug 121782: [GTK] Add --disable-drag-support build option to remove dragging
functionality
https://bugs.webkit.org/show_bug.cgi?id=121782

Attachment 212338: Patch
https://bugs.webkit.org/attachment.cgi?id=212338&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=212338&action=review


r- because you're touching mac-related stuff

> Source/WebCore/WebCore.exp.in:1856
> +#if ENABLE(DRAG_SUPPORT)
>  __ZN7WebCore12EventHandler12mouseDraggedEP7NSEvent
> +#endif

I am not sure this is correct, in any case, I don't think you should change
Mac's symbols export file in a gtk-specific change =)


More information about the webkit-reviews mailing list