[webkit-reviews] review granted: [Bug 121600] [GTK][WK2] A plugin dirtyRect within iframe remains after moving to a different page. : [Attachment 212141] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted ChangSeok Oh
<changseok.oh at collabora.com>'s request for review:
Bug 121600: [GTK][WK2] A plugin dirtyRect within iframe remains after moving to
a different page.
https://bugs.webkit.org/show_bug.cgi?id=121600

Attachment 212141: Patch
https://bugs.webkit.org/attachment.cgi?id=212141&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=212141&action=review


> Source/WebKit2/ChangeLog:8
> +	   Nowhere to destory NetscapePlugin::m_platformPluginWidget even after
destroying

destory -> destroy

> Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:304
> +#if PLATFORM(GTK)
> +    if (m_platformPluginWidget)
> +	   gtk_widget_destroy(m_platformPluginWidget);
> +#endif

The drawable is set to 0, do you know why is that? I think we should do this
here too, for consistency in any case.