[webkit-reviews] review granted: [Bug 120895] [Mac] Implement the media controls in JavaScript. : [Attachment 211474] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 120895: [Mac] Implement the media controls in JavaScript.
https://bugs.webkit.org/show_bug.cgi?id=120895

Attachment 211474: Patch
https://bugs.webkit.org/attachment.cgi?id=211474&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211474&action=review


Only looking over the C++ stuff here, after previous reviews.

> Source/WebCore/DerivedSources.make:858
> +
> +

Nit: extra blank line

> Source/WebCore/html/HTMLMediaElement.cpp:5219
> +    if (overlayValue.isUndefinedOrNull())
> +	   return;

Why don't you do the same as above and test if (!overlayValue.isFunction())) ?

It would be nice if we could share the code to get the DOMWrapperWorld,
ScriptController, JSDOMGlobalObject, ExecState and overlayValue.

> Source/WebCore/html/HTMLMediaElement.h:53
>  #include "VideoTrack.h"
>  #endif
>  
> +
> +
>  namespace WebCore {

??? Intentional?