[webkit-reviews] review granted: [Bug 121614] [CSS Shapes] Fix handling of top margin on float with shape-outside : [Attachment 212078] Patch

[bugzilla-daemon at webkit.org]

Alexandru Chiculita <achicu at adobe.com> has granted Bem Jones-Bey
<bjonesbe at adobe.com>'s request for review:
Bug 121614: [CSS Shapes] Fix handling of top margin on float with shape-outside
https://bugs.webkit.org/show_bug.cgi?id=121614

Attachment 212078: Patch
https://bugs.webkit.org/attachment.cgi?id=212078&action=review

------- Additional Comments from Alexandru Chiculita <achicu at adobe.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=212078&action=review


> Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp:61
> +    LayoutUnit marginBefore =
containingBlock->marginBeforeForChild(m_renderer);
> +    if (marginBefore < 0)
> +	   marginBefore = LayoutUnit();

nit: might look better to use the max(0, value) function instead.