[webkit-reviews] review granted: [Bug 121310] HashMap should work with move-only keys : [Attachment 211911] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 121310: HashMap should work with move-only keys
https://bugs.webkit.org/show_bug.cgi?id=121310

Attachment 211911: Patch
https://bugs.webkit.org/attachment.cgi?id=211911&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211911&action=review


>> Source/WTF/wtf/HashMap.h:140
>> +	    template<typename K, typename V>
>> +	    AddResult inlineSet(K&&, V&&);
> 
> Missing spaces around &&  [whitespace/operators] [3]

Might read better on one line instead of two.

>> Source/WTF/wtf/HashMap.h:143
>> +	    template<typename K, typename V>
>> +	    AddResult inlineAdd(K&&, V&&);
> 
> Missing spaces around &&  [whitespace/operators] [3]

Might read better on one line instead of two.

> Source/WebCore/html/InputType.cpp:90
> -static PassOwnPtr<InputTypeFactoryMap> createInputTypeFactoryMap()
> +static OwnPtr<InputTypeFactoryMap> createInputTypeFactoryMap()

The pattern here should change so we aren’t calling HashMap::add repeatedly,
since those calls will be inlined. Need to do this in a loop instead. I guess I
can make that change after you land. I would suggest we make a static const
table that has two function pointers, one to the function that returns the type
name and the other being the create function.