[webkit-reviews] review granted: [Bug 121185] Avoid copying a hash table bucket when inserting causes a rehash : [Attachment 211358] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 121185: Avoid copying a hash table bucket when inserting causes a rehash
https://bugs.webkit.org/show_bug.cgi?id=121185

Attachment 211358: Patch
https://bugs.webkit.org/attachment.cgi?id=211358&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211358&action=review


> Source/WTF/ChangeLog:8
> +	   Allow rehahsing to track a hash bucket and return the new pointer to
it, thus avoiding

typo: rehashing

> Source/WTF/wtf/HashTable.h:-940
> -	       // FIXME: This makes an extra copy on expand. Probably not that
bad since
> -	       // expand is rare, but would be better to have a version of
expand that can
> -	       // follow a pivot entry and return the new position.

You fixed this FIXME!