[webkit-reviews] review granted: [Bug 120880] [MediaStream API] Updating NavigatorUserMediaError to match the spec : [Attachment 211357] Proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 120880: [MediaStream API] Updating NavigatorUserMediaError to match the
spec
https://bugs.webkit.org/show_bug.cgi?id=120880

Attachment 211357: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=211357&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211357&action=review


> Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:163
> +	   RefPtr<NavigatorUserMediaError> error =
NavigatorUserMediaError::create(ASCIILiteral("PERMISSION_DENIED"), description,
String());
> +	   m_errorCallback->handleEvent(error.get());

I sometimes like the way these read without a local variable. The single line
would be no longer than the first of these two lines of code.