[webkit-reviews] review granted: [Bug 121167] MapData and WeakMapData don't need to be objects : [Attachment 211327] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 121167: MapData and WeakMapData don't need to be objects
https://bugs.webkit.org/show_bug.cgi?id=121167

Attachment 211327: Patch
https://bugs.webkit.org/attachment.cgi?id=211327&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211327&action=review


Nice!

> Source/JavaScriptCore/runtime/MapData.h:82
> +    static const bool needsDestruction = true;
> +    static const bool hasImmortalStructure = true;

I wonder if we should make a JSDestructibleCell base class, to make this easier
in general.