[webkit-reviews] review denied: [Bug 117281] Crash in V8 benchmarks set in ARM, softfp, EABI : [Attachment 211279] verification test

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied Youngho Yoo
<youngho33.yoo at lge.com>'s request for review:
Bug 117281: Crash in V8 benchmarks set in ARM,softfp,EABI
https://bugs.webkit.org/show_bug.cgi?id=117281

Attachment 211279: verification test
https://bugs.webkit.org/attachment.cgi?id=211279&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211279&action=review


> Source/JavaScriptCore/dfg/DFGCCallHelpers.h:571
> +    ALWAYS_INLINE void setupArgumentsWithExecState(TrustedImm32 arg1, FPRReg
arg2, GPRReg arg3)
> +    {
> +	   moveDouble(arg2, FPRInfo::argumentFPR0);
> +	   move(arg3, GPRInfo::argumentGPR1);
> +	   move(GPRInfo::callFrameRegister, GPRInfo::argumentGPR0);
> +    }
> +
> +    ALWAYS_INLINE void setupArgumentsWithExecState(TrustedImm32 arg1, GPRReg
arg2, GPRReg arg3, FPRReg arg4)
> +    {
> +	   moveDouble(arg4, FPRInfo::argumentFPR0);
> +	   setupStubArguments(arg2, arg3);
> +	   move(GPRInfo::callFrameRegister, GPRInfo::argumentGPR0);
> +    }

It looks like arg1 is unused in these functions. Is that a bug? I believe that
shouldn't even build, due to the unused argument warning. Did you test this
code on ARM_HARDFP?