[webkit-reviews] review granted: [Bug 120651] [mac] PDFDocumentImage should use PDFKit to draw : [Attachment 210491] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 4 14:49:04 PDT 2013


Alexey Proskuryakov <ap at webkit.org> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 120651: [mac] PDFDocumentImage should use PDFKit to draw
https://bugs.webkit.org/show_bug.cgi?id=120651

Attachment 210491: patch
https://bugs.webkit.org/attachment.cgi?id=210491&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=210491&action=review


> Source/WebCore/platform/graphics/cg/PDFDocumentImage.h:33
> +#define PDFDOCUMENTIMAGE_USES_PDFKIT (PLATFORM(MAC) && !PLATFORM(IOS))

I'm not sure if this is needed at all, can files be just excluded form build on
platforms that don't need them?


More information about the webkit-reviews mailing list