[webkit-reviews] review granted: [Bug 120695] Refining the StackIterator callback interface : [Attachment 210487] the patch.

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 120695: Refining the StackIterator callback interface
https://bugs.webkit.org/show_bug.cgi?id=120695

Attachment 210487: the patch.
https://bugs.webkit.org/attachment.cgi?id=210487&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
After an in-person conversation:

This patch is an improvement, so I'm going to mark it r+.

Please follow up with a rename from StackIterator to StackVisitor, to avoid
confusion with the C++ term "iterator".

I don't think we've achieved the callback style of implementation that we
originally discussed, but I'm not sure it's super important to get there at
this point.