[webkit-reviews] review granted: [Bug 120397] Replace node() calls with generatingNode() for RenderRegion code : [Attachment 210466] Patch 3

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Mihnea Ovidenie <mihnea at adobe.com>'s
request for review:
Bug 120397: Replace node() calls with generatingNode() for RenderRegion code
https://bugs.webkit.org/show_bug.cgi?id=120397

Attachment 210466: Patch 3
https://bugs.webkit.org/attachment.cgi?id=210466&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=210466&action=review


> Source/WebCore/rendering/RenderRegion.h:40
>  struct LayerFragment;
>  typedef Vector<LayerFragment, 1> LayerFragments;

These should not be in the same paragraph as the straight class definitions.
(Can fix that later, just something I noticed).

> Source/WebCore/rendering/RenderRegion.h:156
> +    Element* generatingElement() const { return
toElement(RenderObject::generatingNode()); }

Can this be zero? If not, it should return a reference.

> Source/WebCore/rendering/RenderTreeAsText.cpp:673
> +	       String tagName = getTagName(renderRegion->node());

Why using node() here instead of generatingElement or generatingNode?