[webkit-reviews] review requested: [Bug 120681] REGRESSION(r154977): Do not urlencode soup message on ResourceRequest::toSoupMessage() : [Attachment 210469] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 4 09:22:39 PDT 2013


Andre Moreira Magalhaes <andrunko at gmail.com> has asked	for review:
Bug 120681: REGRESSION(r154977): Do not urlencode soup message on
ResourceRequest::toSoupMessage()
https://bugs.webkit.org/show_bug.cgi?id=120681

Attachment 210469: Patch
https://bugs.webkit.org/attachment.cgi?id=210469&action=review

------- Additional Comments from Andre Moreira Magalhaes <andrunko at gmail.com>
Updated patch that actually builds (I blame slow builds :D).

What happened is that the buildbot failed for media fragments tests on
http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release/builds/40360
(78 failures over 50 failures on build 40359, all 28 new failures on media
fragments tests) with only the changeset from
http://trac.webkit.org/changeset/154977.

What I find strange is that all media fragments tests work fine here with and
without this new patch to fix the regression (same results):
$ Tools/Scripts/run-webkit-tests --no-new-test-results --debug-rwt-logging
--no-sample-on-timeout --webkit-test-runner LayoutTests/media/media-fragments/
--debug --gtk --iteration=1
...
=> Results: 68/68 tests passed (100.0%)

So, not sure what is happening with the buildbot failures.


More information about the webkit-reviews mailing list