[webkit-reviews] review granted: [Bug 120619] Use OwnPtr in the RenderLayerFilterInfo map : [Attachment 210431] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 120619: Use OwnPtr in the RenderLayerFilterInfo map
https://bugs.webkit.org/show_bug.cgi?id=120619

Attachment 210431: Patch
https://bugs.webkit.org/attachment.cgi?id=210431&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=210431&action=review


> Source/WebCore/rendering/RenderLayerFilterInfo.cpp:50
> +    static Map& map = *new Map;
> +    return map;

I think you can still use NeverDestroyed here.

> Source/WebCore/rendering/RenderLayerFilterInfo.h:51
> +class RenderLayer::FilterInfo
> +#if ENABLE(CSS_SHADERS) && ENABLE(SVG)
> +    FINAL : public CustomFilterProgramClient, public CachedSVGDocumentClient

> +#elif ENABLE(CSS_SHADERS)
> +    FINAL : public CustomFilterProgramClient
> +#else
> +    FINAL : public CachedSVGDocumentClient

I'd just put the FINAL on the previous line instead of duplicating it three
times.

> Source/WebCore/rendering/RenderLayerFilterInfo.h:91
> +    typedef HashMap<const RenderLayer*, OwnPtr<FilterInfo>> Map;
> +    static Map& map();

I think you should just use the HashMap type directly instead of the typedef.